[WIP] Service worker prototype #9123
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he front page loading state lines up Makes it so that if you use the service worker preload for the front page, you get a correctly aligned skeleton of the front page. Tweaks the height of LWPostsItem for bookmarked posts, shrinking it ~1px to make it the same as regular post items, to prevent a mismatch. Removes a stray bottom border from RecommendationsList. Adds a bookmarkCount field to users, to be used to render the bookmarks list on the front page without having to wait for the bookmarked posts. Note that the spotlight item is _not_ handled, so if you haven't dismissed the current spotlight item, it will shift everything down when it appears. If you have dismissed it, though, this looks great.
…o service-worker-prototype
…o service-worker-prototype
…o service-worker-prototype
…o service-worker-prototype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task by Unito