Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Typescript to 4.7.4 #5309

Merged
merged 2 commits into from Jul 18, 2022
Merged

Upgrade Typescript to 4.7.4 #5309

merged 2 commits into from Jul 18, 2022

Conversation

jimrandomh
Copy link
Collaborator

@jimrandomh jimrandomh commented Jul 18, 2022

Upgrade Typescript to the latest version (4.7.4). Fixes a few small things that the new version complains about that the old one didn't (a missing await in an ancient migration, keyof potentially allowing symbol, and spreading a non-object as object props with no effect).

┆Issue is synchronized with this Asana task by Unito

@jimrandomh jimrandomh requested a review from a team as a code owner July 18, 2022 18:34
@jimrandomh jimrandomh requested review from jpaddison3 and removed request for a team July 18, 2022 18:34
@jpaddison3 jpaddison3 self-assigned this Jul 18, 2022
@jimrandomh
Copy link
Collaborator Author

Unit tests failed, failure is real, Jest is complaining that its Typescript configuration has something obsolete in it.

@jpaddison3 jpaddison3 assigned jimrandomh and unassigned jpaddison3 Jul 18, 2022
@jimrandomh
Copy link
Collaborator Author

Unit test failure corresponds to this bug in a distant downstream library: TypeStrong/ts-node#1647 . We depend on ts-node via the indirect dependency path @graphql-codegen/cli -> graphql-config -> consmiconfig -> @endemolshinegroup/cosmiconfig-typescript-loader -> ts-node. This is super duper dead code; not only is @graphql-codegen only used in development-time scripts (not in the client or the server), I'm pretty sure ts-node isn't actually being used by @graphql-codegen, in the way we use it. In any case, pinning ts-node to latest fixed the unit test failure.

@jimrandomh jimrandomh merged commit 1045a12 into master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants