Upgrade Apollo versions #3275
Closed
Upgrade Apollo versions #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinning version of apollo-link because several Apollo versions depend on different versions, and then generate a Typescript type error from the mismatch, and the last point release didn't seem to have anything important in it.
|
I have tested this as far as starting a server and clicking around a bit, but not very thorough. |
|
Yeah, we sadly definitely have to test this thoroughly. Code-wise this is obviously fine, but I don't trust Apollo version upgrades. This might mean we just want to push it to devel, but I do want to make sure you click around for a few minutes before merging. |
Discordius
approved these changes
Jul 2, 2020
|
This PR is obsoleted by #3360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades versions all the Apollo packages (except for
apollo-errors, which is not actually an Apollo package but a weird third party thing we inherited via Vulcan).This resolves the Dependabot version upgrade suggestions in #3244 and #3243 . Those version upgrade suggestions were generated because
apollo-serverhad a vulnerability. However, after reading the CVE details, I don't think the vulnerability impacted us; it was a validator-bypass for a validation-extension API we weren't using. Nevertheless, looking through changelogs, I saw a few mildly nice to have things, and nothing that looked particularly scary.Pinning version of apollo-link because several Apollo versions depend on different versions, and then generate a Typescript type error from the mismatch, and the last point release didn't seem to have anything important in it.