Merge pull request #7942 from ForumMagnum/catch-invalid-image-urls

Skip mirroring images with invalid URLs
ForumMagnum · Oct 4, 2023 · fc67cb6 · fc67cb6
2 parents b7e99a4 + 9ef36e6
commit fc67cb6
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/lesswrong/server/scripts/convertImagesToCloudinary.ts b/packages/lesswrong/server/scripts/convertImagesToCloudinary.ts
@@ -88,11 +88,15 @@ function getImageUrlWhitelist() {
 }
 
 function urlNeedsMirroring(url: string, filterFn: (url: string) => boolean) {
-  const parsedUrl = new URL(url);
-  if (getImageUrlWhitelist().indexOf(parsedUrl.hostname) !== -1) {
+  try {
+    const parsedUrl = new URL(url);
+    if (getImageUrlWhitelist().indexOf(parsedUrl.hostname) !== -1) {
+      return false;
+    }
+    return filterFn(url);
+  } catch (e) {
     return false;
   }
-  return filterFn(url);
 }
 
 async function convertImagesInHTML(html: string, originDocumentId: string, urlFilterFn: (url: string) => boolean = () => true): Promise<{count: number, html: string}> {