Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19423 by defaulting to 0 instead of none #19544

Open
wants to merge 1 commit into
base: 6.x
Choose a base branch
from

Conversation

barryp
Copy link

@barryp barryp commented Feb 2, 2023

"transform: rotate(0);" makes sense as a default if no --fa-rotate-angle is defined.

I understand that:

  • I'm submitting this PR for reference only. It shows an example of what I'd like to see changed but
    I understand that it will not be merged and I will not be listed as a contributor on this project.

"transform: rotate(0);" makes sense as a default if no --fa-rotate-angle
is defined.
@tagliala
Copy link
Member

tagliala commented Feb 3, 2023

Hi!

Thanks for being part of the Font Awesome Community and for this PR

I think this is a legit bug, because we should go either for transform: none or transform: rotate(0), because transform: rotate(none) is not valid

For this specific use case, I think that transform: rotate(0) is the correct way to go.

/cc @robmadole

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants