Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update brand.js #15674

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update brand.js #15674

wants to merge 1 commit into from

Conversation

iamayushdas
Copy link

@iamayushdas iamayushdas commented Oct 10, 2019

I understand that:

  • I'm submitting this PR for reference only. It shows an example of what I'd like to see changed but
    I understand that it will not be merged and I will not be listed as a contributor on this project.

@tagliala
Copy link
Member

Hi,

thanks for this PR.

This file is being generated by our build system, could you please provide the differences between the two approaches?

@iamayushdas
Copy link
Author

Hi,

thanks for this PR.

This file is being generated by our build system, could you please provide the differences between the two approaches?

I have used arrow function in my edition which was not there earlier.

@kamerat
Copy link

kamerat commented Jul 9, 2020

This will break the whole file.
The correct IIFE with arrow function would be:

(() => {
  /* */
})()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants