TypeScript: Some T-shirt sizes not listed in SizeProps

[daven97]

TypeScript error saying that the xl size is invalid.

The docs at https://fontawesome.com/docs/web/style/size has this list of size options:

and the fontawesome-react docs at https://fontawesome.com/docs/web/use-with/react/style#size state:

Font Awesome supports t-shirt size scale from 2xs to 2xl as well as literal sizing from 1x to 10x.

However, looking at @robmadole's changes to SizeProp in https://github.com/FortAwesome/Font-Awesome/blob/65f4bdb5025759ba25cd3432568de288b6a67527/js-packages/%40fortawesome/fontawesome-svg-core/index.d.ts as part of #18652, several of the sizes from the table above are missing, including xl.

The icon is displaying at the correct size, so this is simply a TypeScript error.

[daven97]

I believe this is as simple as updating the type, so I have created this PR: #18789.

[tagliala]

Thanks. I've assigned both @mlwilkerson and @robmadole

[theDanielJLewis]

Thanks for reporting this and creating the PR, @daven97! I'm running into this issue, too. So I'll be grateful when the PR is merged.

[tagliala]

I can see it fixed in 6.2.0

Font-Awesome/js-packages/@fortawesome/fontawesome-svg-core/index.d.ts

Lines 22 to 38 in d3a7818

	export type SizeProp =
	| "2xs"
	| "xs"
	| "sm"
	| "lg"
	| "xl"
	| "2xl"
	| "1x"
	| "2x"
	| "3x"
	| "4x"
	| "5x"
	| "6x"
	| "7x"
	| "8x"
	| "9x"
	| "10x";

[daven97]

Sorry I missed that this issue had been closed. This is working for me now in 6.2.0! Thanks!