New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon size differences when upgrading fortawesome/fontawesome-svg-core to 1.3.0 #18663
Comments
Hi! Thanks for being part of the Font Awesome Community.
This should prevent an upgrade to 6.0.0...
...and it looks like it does, because It may be an issue with Could you please lock If it does not work, please also lock Let me know |
Locking Thanks. |
Welcome, but I will reopen this because this behavior looks like a bug. Is there by any chance to provide a reduced test case in which the database icon looks so big? |
I also have this issue. I did not further investigate as to why this issue occurs but with |
It appears that the class I assume this is related to the release of fontawesome 6.0, but this feels that it should have been included in a major version rather than a minor version bump given it potentially breaks layouts. |
Agree Don't know if this is an issue or the behavior is different in FA6, let's ask @robmadole for some feedback |
Experiencing the same issue on my website on the "dependabot" branch: pedrolamas/pedrolamas.com#3141 That PR has an automatic build showing the problem, just click on the link to see it. Mind you, no other Font Awesome package was updated, just the |
Thanks @pedrolamas I'll take a look at that preview. |
This issue is baffling me. If I update to 1.3.0 I get the big icon issue, but what is happening is that webpack is not including |
I think this issue may be related to #18773 instead |
I am having this issue as well. Please let me know if this should be in a separate issue, but I am also getting a TypeScript error saying that the The docs at https://fontawesome.com/docs/web/style/size has this list of size options: and the fontawesome-react docs at https://fontawesome.com/docs/web/use-with/react/style#size state:
However, looking at @robmadole's changes to In addition to the TypeScript error, the icon doesn't display at a larger size, as if the |
yes please |
It seems latest 6.1.0 version is still having issues: CI build: pedrolamas/pedrolamas.com#3263 |
We weren't able to address this for |
I just noticed that though this issue is marked as being 5.x, it is actually happening on 6.x too! Can someone update this or should a new issue be open? |
I've now managed to fix this in my site, apparently now a Changes here: Running here: |
@robmadole is this issue being tracked anywhere else as well or hasn't there been any updates since last year? I assume this line of the 6.0.0-alpha2 changelog is causing this; Also; this has the '5.x' label but it is a breaking change between 1.2.36 and 1.3.0 (which is now getting updates as 6.x.x) |
I'm using FA Pro icons my project using SVG and JS via vue-fontawesome in Vuetify. Package has everything locked to ^5.15.3.
Since the launch of 6.0.0 the test build (right) deployed using Docker started using the new version and now my icons are larger/smaller than before. My local development version (left) is fine.
Version: 5.13.3
Browser and version: Chrome 97
The text was updated successfully, but these errors were encountered: