Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handlebars dependency to ^4.1.2 #282

Merged
merged 2 commits into from Apr 22, 2019
Merged

Update handlebars dependency to ^4.1.2 #282

merged 2 commits into from Apr 22, 2019

Conversation

juliusl
Copy link
Contributor

@juliusl juliusl commented Apr 22, 2019

Handlebars has a security advisory out for 4.1.1, so yarn/npm audit will complain about ^4.1.0. This is to fix that.

Handlebars has a security advisory out for 4.1.1, so yarn/npm audit will complain about ^4.1.0. This is to fix that.
@juliusl
Copy link
Contributor Author

juliusl commented Apr 22, 2019

Temporary workaround for yarn users is to add to package.json

"resolutions": {
  "handlebars": "^4.1.2"
}

For npm users npm audit fix will work.

@parkerziegler
Copy link
Contributor

parkerziegler commented Apr 22, 2019

Thanks @juliusl! Do you mind re-running yarn install with this change applied in your local brach? We want to make sure that changes to the yarn.lock file also make their way into source (your PR only updates the package.json currently 😄).

@juliusl
Copy link
Contributor Author

juliusl commented Apr 22, 2019

@parkerziegler Sure no problem, pushed new yarn.lock.

@parkerziegler
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants