Added support for node env provide plugin. #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-roemer
approved these changes
Oct 9, 2017
README.md
Outdated
| @@ -59,6 +59,10 @@ You would change that to: | |||
| ``` | |||
| Now you can just run your start script like normal, except now, you are awesome. Not that you weren't before. I'm just saying. More so. | |||
|
|
|||
| ### InspectPack and Node Environments | |||
|
|
|||
| Webpack Dashboard does additional analysis of individual module sizes, asset sizes and any problems when your bundle is unminified and not in a production environment. The Webpack Plugin automatically adds `pathinfo = true` to your configuration’s output object. Environments are defined through the `DefinePlugin` with `process.env["NODE_ENV"]` being `"production"`. Webpack Dashboard will produce a warning if a production configuration is run. | |||
There was a problem hiding this comment.
NIT: s/asset sizes and/asset sizes, and/
plugin/index.js
Outdated
| @@ -2,6 +2,7 @@ | |||
| "use strict"; | |||
|
|
|||
| const _ = require("lodash/fp"); | |||
| const { get } = require("lodash"); | |||
There was a problem hiding this comment.
Uh oh.
- This will break in
node4which is supported. Can you file a ticket with a 1.0 milestone tag that is basically "CI: ensure code works in supported nodes". - For here, just remove and use
_which is already in scope above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For electron webpack dashboard we want to visually show differences when running in production and be more specific in webpack dashboard. This will be needed for FormidableLabs/electron-webpack-dashboard#33.
Addresses #197
DefinePluginexists and safely traverse the object to see if aproductionNODE_ENVvariable is setcc @kenwheeler @ryan-roemer