Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added keyboard navigation for main log. #203

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Added keyboard navigation for main log. #203

merged 1 commit into from
Oct 4, 2017

Conversation

carloskelly13
Copy link

Added Keyboard Navigation for the main log

Addresses #147

  1. Page Up — Scroll to top
  2. Page Down — Scroll to bottom
  3. Up — Scroll up one line
  4. Down — Scroll down one line

cc @kenwheeler @ryan-roemer

@carloskelly13 carloskelly13 added this to the 1.0 milestone Oct 4, 2017
ryan-roemer
ryan-roemer approved these changes Oct 4, 2017
View reviewed changes
Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Need a tire kicking too? If not, feel free to merge.

@carloskelly13 carloskelly13 merged commit f723dcd into master Oct 4, 2017
@carloskelly13 carloskelly13 deleted the keyboard-log-nav branch October 4, 2017 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-roemer ryan-roemer ryan-roemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carloskelly13 @ryan-roemer