Fix WP 3 size reporting, disable inspectpack in minimal #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-roemer
approved these changes
Oct 4, 2017
utils/format-modules.js
Outdated
| @@ -26,7 +26,14 @@ function getModuleName(module) { | |||
| .slice(0, SCOPED_PACKAGE_INDEX) | |||
| .reduce((x, y) => x + y); | |||
| } | |||
| return module.baseName.split("/")[0]; | |||
| const nameComponents = module.baseName.split("/"); | |||
There was a problem hiding this comment.
Is it "/" on Windows? Or do we need like os.sep?
There was a problem hiding this comment.
Good q. Let me fire up the Windows VM and try it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Fix Webpack 3 module reporting. The path names are different so previously we just saw a single entry. Also ensure module reporting still works for Webpack 2.
• Disable analysis with inspectpack when running in minimal mode
• Show better warnings when inspectpack cannot get more data when Webpack is running in production
Addresses #201 #198
Production
Fixed Webpack 3
Webpack 2
cc @ryan-roemer @kenwheeler