Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not output log when errors are present. #200

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

carloskelly13
Copy link

@carloskelly13 carloskelly13 commented Oct 2, 2017

Since we parse and display errors in setStats(data) to the log with this.logText.log(formatOutput(stats)), the errors from the normal log duplicate the messages with extra output. The simple fix is to not log output when we have errors we parsed and are displaying.

Addresses #66

Success
screen shot 2017-10-02 at 3 03 32 pm

Failure
screen shot 2017-10-02 at 3 03 48 pm

cc @ryan-roemer @kenwheeler

@carloskelly13 carloskelly13 added this to the 1.0 milestone Oct 2, 2017
@ryan-roemer
Copy link
Member

@carlospaelinck -- Code looks good. Is there any case that we want to have partial normal output in addition to separate error output (just with error output removed)?

@carloskelly13
Copy link
Author

@ryan-roemer I can't think of any. The regular output is the error plus a lot of module status stuff. Usually the log output is pretty verbose hiding the error forcing the user to scroll. Also not sure how we'd delete out the duplicate error consistently from the log text.

@ryan-roemer
Copy link
Member

OK. SGTM!

@carloskelly13 carloskelly13 merged commit 663bedb into master Oct 2, 2017
@carloskelly13 carloskelly13 deleted the prevent-double-errors branch October 2, 2017 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants