Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minimal sizing of the 3 lower boxes #199

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

carloskelly13
Copy link

@carloskelly13 carloskelly13 commented Oct 2, 2017

Minor fix to allow boxes to have a -1 offset to fit all three boxes in one row depending on the sizing of the terminal window.

Depending on the size of the window, the three sizes of 34%, 34% and 33% can cause an overflow. Testing different sizing configurations, 34%-1, 34%-1 and 33% had the most consistent results of always showing all three boxes on the same row and it consuming most of the full width.

Tested in both Terminal and iTerm.

Addresses #174

t
screen shot 2017-10-02 at 10 51 35 am

cc @ryan-roemer @kenwheeler

@carloskelly13 carloskelly13 added this to the 1.0 milestone Oct 2, 2017
Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. Haven't tested locally -- let me know if you'd like me to...

@carloskelly13
Copy link
Author

carloskelly13 commented Oct 2, 2017

@ryan-roemer I would since it's visual and it'd be great to see if the fix holds up to other terminal configs.

The command is webpack-dashboard --minimal

@carloskelly13 carloskelly13 merged commit 14606c4 into master Oct 2, 2017
@carloskelly13 carloskelly13 deleted the minimal-sizing-fix branch October 2, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants