Feature - Add plugin host option #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… act as server and what act as client
|
@ryan-roemer can you take a look on this please? :) |
|
Fixed the conflicts with the recently added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I work on many projects at same time, to not deal with port issues on them I usually dockerize the servers (a small performance trade-off for the convenience).
The problem is that the best place to run the webpack-dashboard server is in my local terminal and the new electrum-webpack-dashboard we have no choice...
As a solution, we can add the option to change where the client will connect, in this case, I can expose my host IP to the container, and it will connect the port and provide the socket communication.
In the documentation, I have added the
hostoption and a bit of clarification of what is server and what is client in this project. I know many people don't care, but that would save me a lot of time to understand how it works, instead of going to the source code to figure out.I really appreciate the work in this plugin and hope to help with this contribution.