use different GitHub token for Version Packages #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-roemer
reviewed
Sep 21, 2022
ryan-roemer
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Nice find! One small comment suggestion, rest looks great!
I know @scottrippey is going to be disappointed he doesn't get to repeatedly close/re-open Version Packages PRs anymore 😛
|
The workaround is just so fun though! It's like I'm lighting up a Christmas tree! 🎄🎄🎄 |
scottrippey
approved these changes
Sep 21, 2022
scottrippey
requested changes
Sep 21, 2022
Will add some instructions to the PR! |
scottrippey
reviewed
Sep 22, 2022
scottrippey
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help resolve #2434 - I believe this thread and solution outline a potential temporary fix.
A token was generated (details to be provided in Slack) and this has been setup in the
release.ymlworkflow.Hopefully this works and correctly runs the workflows as the
victory-ciuser without us needing to close and re-open the PR!We will need to test this properly after a merge to review if the "Version Packages" PR that is opened runs the CI tests/suite as expected. If it does, we do not need to revert this change. If it does not, then this change has not been worthwhile in fixing this bug