-
Notifications
You must be signed in to change notification settings - Fork 694
Feature/kbar #1161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/kbar #1161
Conversation
…ar shortcut integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! A couple small questions, and would be great to have @carlos-kelly kick the tires on this too!
packages/spectacle/src/components/command-bar/results/index.tsx
Outdated
Show resolved
Hide resolved
packages/spectacle/src/components/command-bar/results/index.tsx
Outdated
Show resolved
Hide resolved
Oh and also, @mwritter – can you add a commit to this branch with a changeset? Should be able to run something like: pnpm changeset and then select "minor" for "spectacle", with a note about the kbar implementation. That way, we'll have the changelog record ready when we go to publish this release! |
Also let's use the same font styling as we do for Presenter mode
|
It would make sense 🤔 - What do we think about this @carlos-kelly @gksander |
Co-authored-by: Ryan Roemer <ryan.roemer@formidable.com>
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Added Kbar integration to see current keybindings and to preform actions. Dependency added:
"kbar": "0.1.0-beta.36"
inpackages/spectacle/package.json
Fixes #1115
Type of Change
Please delete options that are not relevant (including this descriptive text).
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Added unit test for
use-modes.ts
, and 'platform-keys.ts'.use
mod+k
to view/test feature.Checklist: (Feel free to delete this section upon completion)
yarn format
)yarn test
)