Skip to content

Feature/kbar #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 28, 2022
Merged

Feature/kbar #1161

merged 24 commits into from
Jul 28, 2022

Conversation

mwritter
Copy link
Contributor

@mwritter mwritter commented Jul 27, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Added Kbar integration to see current keybindings and to preform actions. Dependency added: "kbar": "0.1.0-beta.36" in packages/spectacle/package.json

Fixes #1115

Type of Change

Please delete options that are not relevant (including this descriptive text).

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Added unit test for use-modes.ts, and 'platform-keys.ts'.
use mod+k to view/test feature.

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My code follows the style guidelines of this project (I have run yarn format)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (I have run yarn test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Sorry, something went wrong.

@mwritter mwritter self-assigned this Jul 27, 2022
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! A couple small questions, and would be great to have @carlos-kelly kick the tires on this too!

@gksander
Copy link
Contributor

Oh and also, @mwritter – can you add a commit to this branch with a changeset? Should be able to run something like:

pnpm changeset

and then select "minor" for "spectacle", with a note about the kbar implementation. That way, we'll have the changelog record ready when we go to publish this release!

@carloskelly13
Copy link
Contributor

Screen Shot 2022-07-28 at 12 05 06 PM

I really like it, wonder if it's worth adding a "return to default mode" when any of the 4 modes are picked

@carloskelly13
Copy link
Contributor

Also let's use the same font styling as we do for Presenter mode

import { SYSTEM_FONT } from 'utils/constants';

@mwritter
Copy link
Contributor Author

mwritter commented Jul 28, 2022

I really like it, wonder if it's worth adding a "return to default mode" when any of the 4 modes are picked

It would make sense 🤔 - What do we think about this @carlos-kelly @gksander
Screen Shot 2022-07-28 at 2 37 13 PM

Co-authored-by: Ryan Roemer <ryan.roemer@formidable.com>
@mwritter mwritter merged commit 2d5198b into main Jul 28, 2022
@mwritter mwritter deleted the feature/kbar branch July 28, 2022 20:55
This was referenced Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command bar for common Spectacle operations
4 participants