Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the example to match prism examples structure #118

Closed
wants to merge 1 commit into from

Conversation

JaKXz
Copy link

@JaKXz JaKXz commented Jun 16, 2021

As documented here: https://prismjs.com/#basic-usage

and fixes #137 a small typo :)

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@JaKXz
Copy link
Author

JaKXz commented Jun 21, 2021

@dekked the getLineProps and getTokenProps methods actually return the key prop and put it on the rendered element, if I understand correctly :)

@dekked
Copy link

dekked commented Jun 21, 2021

Oh, that's right... but I still get my linter complaining :)

@JaKXz
Copy link
Author

JaKXz commented Apr 27, 2022

I'm not sure this applies anymore (because of some writing I found about the code and pre elements)... @jpdriver happy to reopen if you think it's useful!

@JaKXz JaKXz closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants