[+] Technical - Warn users if an update of Lumber is available #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root-io
force-pushed
the
feature/warn-new-update
branch
3 times, most recently
from
a74e04e
to
c6f634f
Compare
root-io
force-pushed
the
feature/warn-new-update
branch
from
c6f634f
to
e46dd9d
Compare
arnaudbesnier
requested changes
Mar 24, 2019
|
I think that's because the packages versions are set with |
arnaudbesnier
force-pushed
the
feature/warn-new-update
branch
from
e46dd9d
to
2de5e0b
Compare
SeyZ
force-pushed
the
feature/warn-new-update
branch
2 times, most recently
from
8cb6e25
to
90ba453
Compare
SeyZ
force-pushed
the
feature/warn-new-update
branch
from
90ba453
to
7c0b953
Compare
|
It's a great nice to have but honestly, I'm not a big fan to have a subprocess ran to check the version. It means when something goes wrong for any reason (process.exit(1)), the subprocess is still running. In addition, there're some issue related to the subprocess: yeoman/update-notifier#140. I prefer to close this PR at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.