-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tokenize with capture groups #638
Conversation
@devatwork could you help me out here? It seems like my push access to the repo is revoked. Didn't we end up at me retaining |
BundleMonFiles updated (2)
Total files change +80B +0.05% Final result: ✅ View report in BundleMon website ➡️ |
Fixes a few tests as well
@Erikvl87 Can you advice? |
@DrRataplan Could you try to add at least 1 reviewer and get approval before merging? |
I am unable to add reviewers. @bwrrp could you review this somewhere this week? No hurry. |
@DrRataplan, the individual |
It works. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! TIL about RegExp.prototype[@@split] and its behavior around capture groups.
Fixes a few tests as well!
Also fixes #635. Thanks @rrthomas for finding it!