Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokenize with capture groups #638

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

DrRataplan
Copy link
Collaborator

Fixes a few tests as well!

Also fixes #635. Thanks @rrthomas for finding it!

@DrRataplan
Copy link
Collaborator Author

@devatwork could you help me out here? It seems like my push access to the repo is revoked. Didn't we end up at me retaining maintainer rights?

Copy link

bundlemon bot commented May 14, 2024

BundleMon

Files updated (2)
Status Path Size Limits
fontoxpath.js
78.11KB (+42B +0.05%) -
fontoxpath.esm.js
78.22KB (+38B +0.05%) -

Total files change +80B +0.05%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Fixes a few tests as well
@coveralls
Copy link

coveralls commented May 14, 2024

Coverage Status

coverage: 91.599% (+0.005%) from 91.594%
when pulling 148ea10 on DrRataplan:regex-fix
into 93d53cc on FontoXML:master.

@devatwork
Copy link
Contributor

@Erikvl87 Can you advice?

@Erikvl87
Copy link
Member

Erikvl87 commented May 14, 2024

@DrRataplan Could you try to add at least 1 reviewer and get approval before merging?

@DrRataplan
Copy link
Collaborator Author

I am unable to add reviewers. @bwrrp could you review this somewhere this week? No hurry.

@Erikvl87 Erikvl87 requested a review from bwrrp May 14, 2024 16:31
@Erikvl87
Copy link
Member

Erikvl87 commented May 15, 2024

@DrRataplan, the individual Maintain permission granted to you was inadvertently revoked during your removal from the FontoXML organization. You have been re-assigned the Maintain role, which should resolve the issue of not being able to add the required reviewers.

@DrRataplan
Copy link
Collaborator Author

It works. Thanks!

Copy link
Member

@bwrrp bwrrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! TIL about RegExp.prototype[@@split] and its behavior around capture groups.

@bwrrp bwrrp merged commit 634d9d1 into FontoXML:master May 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with tokenize or regexs
5 participants