New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify FodyPackaging #660
Conversation
ping @glennawatson |
Fine by me, already using my own packaging mechanism. Why not create docs for the real minimum requirements like the code below: Then everyone can use the methods they prefer. |
@GeertvanHorrik yep working on proper doco ATM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This is a good time to make this change, especially as Fody already goes 4.0 and NuGet deprecated PackageLicenseUrl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonCropp this will require to update https://github.com/Fody/Fody/wiki/HowToWriteAnAddin as well!
Up to now it was very smart and easy to create a new weaver if it follows some standards - however if it's only about adding four new properties, that's not too much a change.
+1 |
For those using Azure DevOps/Pipelines, make sure you have latest .NET SDK 2.1.x, MSBuild picks up the SDK with the LicenseExpression from there. |
This is a breaking change to FodyPackaging.
Some history: FodyPackaging was originally created to only build packages from within the Fody Org. As such many things were hard coded (or specified with a rigid convention) eg license, icon, output dir, project url. FodyPackaging was then made more flexible so it could target projects outside the Fody Org. This was a good change, but had some side effects
Moving forward i believe this will be difficult to document and to maintain
This PR remove those conventions that are complex or overly presumptuous.
All downstream weavers that consume FodyPackaging would need to set their own