Base load contexts on weaver paths #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-englert
approved these changes
May 10, 2024
|
Just FYI, the 6.8.1 release notes did not include #1224 for some reason, I had to add them manually. |
|
@ltrzesniewski oops, maybe this was hidden among the hundreds of dependabot PR links that I had to remove. |
|
Yeah no worries, dependabot is a mess 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Fody creates an assembly load context per solution directory. A problem with that approach is that if two projects in the same solution try to load two different versions of the same weaver on a single build node, the second load will fail.
This PR changes this logic to create assembly load contexts based on the set of weaver assembly paths which will be used in a given project. Therefore, two projects which use two different versions of the same weaver will get two different load contexts since the weaver path won't be the same (and even if it were the same path, the
WeaversHistoryclass already takes care of this case).Note that I may be missing some context here (I don't know why the load contexts were cached by solution path or why they were cached in the first place).
Closes #1268