Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package_parameter_enabled being ignored for Flare, Rive and Lottie #300

Merged
merged 4 commits into from Sep 29, 2022
Merged

Fix package_parameter_enabled being ignored for Flare, Rive and Lottie #300

merged 4 commits into from Sep 29, 2022

Conversation

davidmigloz
Copy link
Contributor

@davidmigloz davidmigloz commented Sep 28, 2022 •
edited

What does this change?

package_parameter_enabled was being ignored for Flare, Rive, and Lottie integrations.

Fixes #274

Refs:

@wasabeef wasabeef self-requested a review September 28, 2022 09:29
@wasabeef wasabeef added this to the 5.0.1 milestone Sep 28, 2022
@wasabeef
Copy link
Member

@davidmigloz
Thank you for your PR. I'll release v5.0.1 with the codes this week.

@wasabeef wasabeef merged commit a5b3700 into FlutterGen:main Sep 29, 2022
@wasabeef wasabeef mentioned this pull request Sep 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasabeef wasabeef Awaiting requested review from wasabeef wasabeef is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

Rive integration ignores package_parameter_enabled: true
2 participants
@davidmigloz @wasabeef