Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deserialization with System.Text.Json (#1928) #1947

Merged
merged 2 commits into from May 27, 2022

Conversation

JeremySkinner
Copy link
Member

@JeremySkinner JeremySkinner commented May 26, 2022

Fixes #1928

  • Adds public constructor to ValidationFailure
  • Adds setter to ValidationResult.Errors
    • Setter creates a copy of the list and removes nulls for consistency with the existing public constructor
  • Makes the ValidationResult.RuleSetsExecuted setter public
  • Minor cleanup to a few doc comments.
  • Adds tests (ported from fix: json deserialization issue of ValidationResult #1935 with some modifications)

@JeremySkinner JeremySkinner force-pushed the issue/1928-stj_serialization branch 2 times, most recently from eb97f54 to 0da9eb7 Compare May 26, 2022 11:33
@JeremySkinner JeremySkinner changed the title Support deserialization with System.Text.Json Support deserialization with System.Text.Json (#1928) May 26, 2022
@JeremySkinner JeremySkinner merged commit f4a7a16 into main May 27, 2022
@JeremySkinner JeremySkinner deleted the issue/1928-stj_serialization branch May 29, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Text.Json is unable to deserialize FluentValidation.Results.ValidationResult
1 participant