Downgrade Axios to 1.1.3 #1396
Merged
Downgrade Axios to 1.1.3 #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hardillb / @knolleary Should we be cutting a new release of FF for this fix or will it go into 1.2? |
|
We only use axios to access our own APIs... so I'm not sure if we're exposed here to warrant pushing a release out. |
|
This is only an issue when running in nodejs, anything in the browser is safe by the look of things |
hardillb
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses* #1390 by downgrading Axios to a version without issues handling Brotli.
See: axios/axios#5357 and axios/axios#5346 for the issues with 1.2.0 and 1.2.1 respectively.