Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5707 Replace "email password" with "message password" in the Secure Compose window #5708

Merged
merged 1 commit into from May 9, 2024
Merged

#5707 Replace "email password" with "message password" in the Secure Compose window #5708

merged 1 commit into from May 9, 2024

Conversation

vahram-papazyan
Copy link
Collaborator

@vahram-papazyan vahram-papazyan commented May 9, 2024 •
edited by sosnovsky

This PR replaces "email password" with "message password" in the Secure Compose window

close #5707

Before
email

After
msg

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

sosnovsky
sosnovsky approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky enabled auto-merge (squash) May 9, 2024 17:21
@sosnovsky sosnovsky merged commit 73bde32 into master May 9, 2024
13 of 14 checks passed
@sosnovsky sosnovsky deleted the issue-5707-replace-email-password-with-message-password branch May 9, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace "email password" with "message password" in the Secure Compose window
2 participants
@vahram-papazyan @sosnovsky