Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #4078 End passphrase button z index run gmail tests #4152

Merged

Conversation

limonte
Copy link
Contributor

@limonte limonte commented Nov 29, 2021

This PR puts the end pp session in front of google chat popups on hover to improve UX:

CleanShot.2021-11-29.at.21.44.22.mp4

close #4078


Also fixed a small issue with the encrypted subject's look:

before after
CleanShot 2021-11-29 at 16 40 20@2x CleanShot 2021-11-29 at 16 40 37@2x

Also bumped puppeteer to v12.0.1 as live gmail tests were failing with v12.0.0 because of this issue: https://flowcrypt.semaphoreci.com/jobs/8c3c44f4-1ffc-412c-b73c-62b435a48d2a + fixed a flaky test with weird puppeteer issue typing 'ompose draftc' instead of 'compose draft'


Tests (delete all except exactly one):

  • Not worth testing

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@limonte limonte marked this pull request as draft November 29, 2021 20:30
@limonte limonte marked this pull request as ready for review November 29, 2021 21:04
@limonte limonte changed the title Issue 4078 end passphrase button z index run gmail tests Issue #4078 end passphrase button z index run gmail tests Nov 29, 2021
@limonte limonte changed the title Issue #4078 end passphrase button z index run gmail tests issue #4078 End passphrase button z index run gmail tests Nov 29, 2021
@rrrooommmaaa rrrooommmaaa merged commit 1779073 into master Nov 30, 2021
@rrrooommmaaa rrrooommmaaa deleted the issue-4078-end-passphrase-button-z-index-run-gmail-tests branch November 30, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"end pass phrase session" conflicts with google chat?
2 participants