[fix] pyparsing: lock pyparsing to 2.4.7 fixing webui log page #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a hell of a time fighting with pip-compile and getting everything working last time I messed with deps. I think we should just manually do the edits right now to only pin pyparsing so we don't have to mess with tweaks to get all the python versions working. |
|
Yeah agreed that makes sense, i'll do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
The Log page on webui is broken after we updated pyparsing. I'm going to look into this further so we can update pyparsing properly but for now want to lock it back to 2.4.7.
Detailed changes:
Addressed issues: