Skip to content

Commit

Permalink
Test on 8.1 and 8.2 (#33)
Browse files Browse the repository at this point in the history
* Test on 8.1 and 8.2

* Bump min phpunit version: sebastianbergmann/phpunit#4575

* Add attribute for newer php versions

* Fix warning about possible missing offset
  • Loading branch information
Firehed committed Oct 18, 2022
1 parent 68e8d8c commit 7449d13
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ jobs:
- '7.3'
- '7.4'
- '8.0'
- '8.1'
- '8.2'

steps:
- name: Check out code
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"phpstan/phpstan": "^1.0",
"phpstan/phpstan-phpunit": "^1.0",
"phpstan/phpstan-strict-rules": "^1.0",
"phpunit/phpunit": "^8.5 || ^9.0",
"phpunit/phpunit": "^8.5.14 || ^9.0",
"squizlabs/php_codesniffer": "^3.5"
},
"scripts": {
Expand Down
1 change: 1 addition & 0 deletions src/Compiler.php
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ private function makeNameForKey(string $key): string
private function tryToMakePathWritable(string $destFile): void
{
$pathInfo = pathinfo($destFile);
assert(array_key_exists('dirname', $pathInfo));

if (is_writable($pathInfo['dirname'])) {
// Directory exists and is writable, should be ok.
Expand Down
1 change: 1 addition & 0 deletions tests/Fixtures/SessionHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public function destroy($session_id): bool
* @param int $maxlifetime
* @return int|false
*/
#[\ReturnTypeWillChange]
public function gc($maxlifetime)
{
return 0;
Expand Down

0 comments on commit 7449d13

Please sign in to comment.