Move static config in modules to constructor

See also testcontainers/testcontainers-java#2473
FirebirdSQL · Aug 2, 2020 · d73893a · d73893a
1 parent 039d7d8
commit d73893a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,7 +4,9 @@ Version History
 1.0.4
 -----
 
-- Update org.testcontainers:jdbc to 1.14.3 
+- Update org.testcontainers:jdbc to 1.14.3
+- Move static config in modules to constructor (see also https://github.com/testcontainers/testcontainers-java/pull/2473)
+
 
 1.0.3
 -----

diff --git a/src/main/java/org/firebirdsql/testcontainers/FirebirdContainer.java b/src/main/java/org/firebirdsql/testcontainers/FirebirdContainer.java
@@ -34,11 +34,11 @@ public FirebirdContainer() {
 
     public FirebirdContainer(String dockerImageName) {
         super(dockerImageName);
+        addExposedPort(FIREBIRD_PORT);
     }
 
     @Override
     protected void configure() {
-        addExposedPort(FIREBIRD_PORT);
         addEnv("TZ", timeZone);
         addEnv("FIREBIRD_DATABASE", databaseName);