Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version of firebase-tools used for deploys. #242

Closed
mikelehen opened this issue Oct 6, 2022 · 5 comments · Fixed by #246
Closed

Pin version of firebase-tools used for deploys. #242

mikelehen opened this issue Oct 6, 2022 · 5 comments · Fixed by #246
Labels
enhancement New feature or request

Comments

@mikelehen
Copy link

The use case you're trying to solve

Github deploys work reliably from day to day.

Change to the action that would solve that use case

Instead of installing the latest firebese-tools every time, pin to a version that is known to work correctly and only update it periodically. Perhaps allow developers to override the version if they choose.

Other considerations

For context, the firebase-tools@11.14.0 release had a regression that broke deploys for many firebase projects. firebase/firebase-tools#5071

I don't need my automatic deploys to be using the absolute latest version of firebase-tools. I'd rather it only update occasionally so that I'm not subject to surprise breakages.

@davideast
Copy link
Collaborator

Hey @mikelehen! I think adding a version override is more than a reasonable option for starters. I'll look into some options for improvement here and get back to you.

@aaronadamsCA
Copy link

+1 to pinning the dependency. I know it would require an action release every time the internal version was to be updated; but this would be correct, and would mirror the way other GitHub Actions generally work.

@drummerjolev
Copy link

+1, great idea @mikelehen

@mikelehen
Copy link
Author

Awesome, thanks @davideast!

@jhuleatt jhuleatt linked a pull request Oct 13, 2022 that will close this issue
@jhuleatt
Copy link
Collaborator

Thanks for the feedback all! firebaseToolsVersion is now available as an option thanks to #246. For now, we're going to keep @latest as the default behavior.

@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants