Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .finished() to NestedSubsystem, add sequential shutdown example #82

Merged
merged 5 commits into from Feb 7, 2024
Merged

Add .finished() to NestedSubsystem, add sequential shutdown example #82

merged 5 commits into from Feb 7, 2024

Conversation

Finomnis
Copy link
Owner

@Finomnis Finomnis commented Feb 7, 2024 •
edited

Fixes #80.

@Finomnis Finomnis mentioned this pull request Feb 7, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20f5671) 99.69% compared to head (573c7f5) 99.84%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   99.69%   99.84%   +0.14%     
==========================================
  Files          14       14              
  Lines         654      640      -14     
  Branches      654      640      -14     
==========================================
- Hits          652      639      -13     
+ Partials        2        1       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Finomnis Finomnis changed the title Add .finished() to NestedSubsystem, add sequential shutdown example, bump miette to 7.0 Add .finished() to NestedSubsystem, add sequential shutdown example Feb 7, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 7, 2024
View reviewed changes
tests/integration_test_2.rs Fixed Show fixed Hide fixed
tests/integration_test_2.rs Fixed Show fixed Hide fixed
@Finomnis Finomnis force-pushed the sequential_shutdown branch 2 times, most recently from 09d45dc to 13b9280 Compare February 7, 2024 10:54
@Finomnis Finomnis merged commit f10debd into main Feb 7, 2024
18 checks passed
@Finomnis Finomnis deleted the sequential_shutdown branch February 7, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sequential shutting down of subsystems after SIGINT/SIGTERM received
1 participant
@Finomnis