[EI-4701] - Use regex to validate system codes instead of making HTTP calls to biz-ops-system-codes #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…z ops system codes
kiyaGu
changed the title
notlee
approved these changes
Apr 26, 2024
|
Thanks @kiyaGu! Decommission all the things🔥 |
notlee
added
the
release:patch
|
🎉 This PR is included in version v366.4.6 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We had a discussion with the Origami team (@notlee) regarding the decommissioning of Biz Ops system codes and we have agreed that it is not essential to verify if a system code is valid or not by making HTTP call to biz-ops-system-codes we can simply use a regex patter to check if it is a valid Biz ops system code.
What
Anything in particular you'd like to highlight to reviewers?
The regex I have used is taken from Biz ops schema which Biz ops uses to validate system codes