Delete labels feature #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
RomuloVitoi
approved these changes
Feb 27, 2023
Co-authored-by: Rômulo Vitoi <romvitoi@gmail.com>
|
Thanks for taking a look @RomuloVitoi - suggestions committed, good idea there with defaulting to false! |
|
Hi @notlee, any chance to review this PR? 🙏🏼 |
notlee
added
the
release:minor
notlee
approved these changes
Mar 8, 2023
|
That's released in 2.3.0 :) |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #182
This PR introduces an optional
deleteflag for labels. Whentrue, matching labels will always be deleted. This can be used in conjunction with theallowAddedLabelsflag to mark a subset of labels for deletion while leaving others intact, allowing more fine-grained control over label management.Labels in the local configuration that are missing in the remote will not be created if they are flagged for deletion in the config.
In order to facilitate overriding
allowAddedLabels, logic forallowAddedLabelshas been moved down intocalculateLabelDiff- I considered some alternatives but this felt like the cleanest way to do it, though additional feedback and suggestions are very welcome! Tests and readme have been updated accordingly.