Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage #32 #33

Closed
wants to merge 1 commit into from

Conversation

martinfrances107
Copy link
Collaborator

Add a new script "npm run coverage" which appends a code coverage report to the end of the standard test result.

@Fil
Copy link
Owner

Fil commented Apr 19, 2021

Definitely feels as an improvement, and I don't mind using d3-geo-voronoi as a test bed for this. But it might be nice to see if it fits the new test framework that @mbostock is envisaging in d3/d3#3469

@martinfrances107
Copy link
Collaborator Author

Thanks for drawing my attention to the more complete topic

I would be good to do this in a uniform way...

I just tried to add my "get it done hot fix" to d3-delaunay and now I understand more completely why the quick fix did not work there

a uniform approach is needed.

I need to focus on the porting to rust .. doing 3 ports at once is more than I can handle.

So I am quite happy to keep this a useful local branch on my fork of this module.... you can close this issue if you like.

@Fil
Copy link
Owner

Fil commented Apr 27, 2021

The new tooling is ready #35

@Fil Fil closed this Aug 31, 2021
@martinfrances107 martinfrances107 deleted the code_coverage branch August 31, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants