Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WstxEventFactory: Ensure events' immutable non-null location #205

Merged
merged 3 commits into from Apr 30, 2024
Merged

WstxEventFactory: Ensure events' immutable non-null location #205

merged 3 commits into from Apr 30, 2024

Conversation

stanio
Copy link
Contributor

@stanio stanio commented Apr 6, 2024

Addresses #204:

  • Ensure events with non-null location
  • Ensure events with non-volatile location

The latter is a secondary issue noted in the original report.

@stanio
WstxEventFactory: Ensure events with non-null location
8a135d2 
This should probably be handled already in the abstract base
Stax2EventFactoryImpl, or it should document (@implNote) subclasses have
to override and implement setLocation() explicitly to be conformant.
@stanio
WstxEventFactory: Ensure events with non-volatile location
2f1ed91 
>   The values are copied by value into the events created by this factory.
@stanio
Copy link
Contributor Author

stanio commented Apr 22, 2024

@cowtowncoder, would you review this, when you get the time?

@cowtowncoder
Copy link
Member

Hi @stanio! Thank you for contributing this & apologies for slow follow-up.

I am traveling for work this week but will try to review this when I get home.

@cowtowncoder
Copy link
Member

@stanio I am now reviewing this and it looks good so far so I think there won't be issues.

But one last process thing before I can merge the fix is to get a CLA from

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(unless you have sent one for Woodstox or Jackson contributions).
It's usually easiest to print, fill & sign, scan/photo, email to cla at fasterxml dot com.
Once we get it, CLA is good for any and all contributions to FasterXML projects so it's one-time-only thing.

Looking forward to merging this; will now complete the review.

cowtowncoder
cowtowncoder approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cowtowncoder
Copy link
Member

Ok, so after getting CLA & merging, I think I'll backport this into 6.6 for inclusion in 6.6.3 (should be easy to cherry-pick).

Thank you again for contributing this!

@stanio
Copy link
Contributor Author

stanio commented Apr 29, 2024

I have sent my CLA earlier today.

@cowtowncoder cowtowncoder merged commit dbef4a9 into FasterXML:master Apr 30, 2024
4 of 5 checks passed
cowtowncoder pushed a commit that referenced this pull request Apr 30, 2024
@stanio @cowtowncoder
WstxEventFactory: Ensure events' immutable non-null location (#205)
17a3eb2
@cowtowncoder cowtowncoder added this to the 6.7 milestone Apr 30, 2024
@cowtowncoder
Copy link
Member

Merged into master for eventual 7.0.0, but also backported into 6.x for 6.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stanio @cowtowncoder