Changes / fixes for Issue #67 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong line for XML event location in elements following DTD - Added additional comment coverage in TestComments.java - Added test per Issue FasterXML#67 writeup to TestLocation.java - Carriage was not being checked so skipped, added check and call to skipCRLF(c) to advance line number.
|
Oh. One thing before merging: if I haven't yet asked for CLA, I'd need one from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf (used for Woodstox as well as Jackson). It only needs to be sent once before the first contribution; after that good for all contributions. If you have sent one before (I tried checking but might have missed it) just let me know. Otherwise it's easiest to print, fill & sign, scan/photo, send to Once I have it I can proceed with merge. Thank you for the PR; looking forward to merging it! |
|
Your change looks good to me, I will work on the cla tomorrow night.
…On Sun, Dec 17, 2023, 7:50 PM Tatu Saloranta ***@***.***> wrote:
Oh. One thing before merging: if I haven't yet asked for CLA, I'd need one
from:
https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf
(used for Woodstox as well as Jackson). It only needs to be sent once
before the first contribution; after that good for all contributions. If
you have sent one before (I tried checking but might have missed it) just
let me know.
Otherwise it's easiest to print, fill & sign, scan/photo, send to cla at
fasterxml dot com.
Once I have it I can proceed with merge.
Thank you for the PR; looking forward to merging it!
—
Reply to this email directly, view it on GitHub
<#186 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BA7WS6VNEXR5JPGIHKXEEW3YJ6HPHAVCNFSM6AAAAABAXPREPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGM3DIMBQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Perfect! Thank you @Orbisman. |
|
CLA sent...
…On Sun, Dec 17, 2023 at 8:29 PM Tatu Saloranta ***@***.***> wrote:
Perfect! Thank you @Orbisman <https://github.com/Orbisman>.
—
Reply to this email directly, view it on GitHub
<#186 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BA7WS6XLTQON5IAXH3AOKLTYJ6MA7AVCNFSM6AAAAABAXPREPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGM4TEMBUGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
CLA received, will merge. |
cowtowncoder
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong line for XML event location in elements following DTD