Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow jackson-module-jaxb-annotations to tolerate 2.2,3 in Import-Package #235

Open
wants to merge 1 commit into
base: 2.16
Choose a base branch
from

Conversation

JDUNNIN
Copy link

@JDUNNIN JDUNNIN commented Jan 12, 2024

Resolves #233

I removed the Jakarta import, from the comment Despite groupId, this is "old" JAXB, not Jakarta (3.x is real Jakarta one) it sounds like this should be OK. The end result in the MANIFEST.MF was the same as when I just added the jaxb-api dependency above it.

image

<version>${version.jaxb.impl}</version>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
<version>2.2.12</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this instead change version.jaxb.impl property?

@cowtowncoder
Copy link
Member

Hmmh. I am really uncomfortable with this change -- I know JAXB/Jakarta upgrade has been a Royal Mess, and I am not sure this helps in general. It seems to me that there are TWO overlapping distinct packages (as in, different Maven coordinates) that nonetheless both provide same classes: one with 2.2.x version (one chosen here) and another 2.3.x (one being replaced). I don't think Maven can express such either-or case.
It seems like this could easily break existing usage with 2.3 dependency?

And in particular making change in a patch of 2.16, if breaking, would be very unfortunate. Especially as we are downgrading a dependency.

Is it not possible to add local overrides on package depending on JAXB annotations module?

@GedMarc WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants