Fix regression for JAXB annotations by implementing findEnumValues(MapperConfig, AnnotatedClass, Enum[], String[])
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
commented
Jun 21, 2023
| } | ||
| return names; | ||
| } | ||
|
|
There was a problem hiding this comment.
All same wrt to original method, except line 964 w/ @XmlEnumValue
JooHyukKim
commented
Jun 21, 2023
| } | ||
| } | ||
| return names; | ||
| } |
There was a problem hiding this comment.
@cowtowncoder Changes in JakartaXmlBindAnnotationIntrospector alone will fix the build failure. But if I understood correctly, this JaxbAnnotationIntrospector needs implementation here also...?
There was a problem hiding this comment.
Correct, thanks. I think build fails on first module failing to pass tests so since "jakarta-xmlbind" is run before "jaxb" it'll be one breaking build.
cowtowncoder
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #211