Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afterburner: #174 handle primitive/string property with ser #178

Closed
wants to merge 2 commits into from

Conversation

BOFA1ex
Copy link

@BOFA1ex BOFA1ex commented May 25, 2022

link #174
Using serializer to handle it like ObjectFieldPropertyWriter/ObjectMethodPropertyWriter

@cowtowncoder
Copy link
Member

Um, no. What problem is this supposed to fix? It adds overhead and seems against the idea of avoiding unnecessary checks. Optimized BeanPropertyWriters should only be assigned when there is only the Jackson standard implementation and we can fully optimize handling.

Under what conditions would this change be needed?

I'd at least need to see a test of something that does not work without change presented.

@cowtowncoder
Copy link
Member

Um, no. What problem is this intended to fix? It adds overhead and seems against the idea of avoiding unnecessary checks. Optimized BeanPropertyWriters should only be assigned when there is only the Jackson standard implementation and we can fully optimize handling.

Under what conditions would this change be needed?

I'd at least need to see a test of something that does not work without change presented.

@BOFA1ex
Copy link
Author

BOFA1ex commented May 26, 2022

Before afterburner using SerializerModifier to change BeanPropertyWriter, there have another modifier to assign serializer in it. and then the serializer is declare with @JacksonStdImpl, it will skip the check (SerializerUtil.isDefaultSerializer(bpw.getSerializer()).

But primitive/string method writer do nothing after access#getValue just gen.writeString(value).
if not declare with @JacksonStdImpl, it using reflect not asm, so why did i try to append AfterBurnerModule to improve pref.

@BOFA1ex BOFA1ex closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants