New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Help needed] Fix custom null serialization #182
base: 2.10
Are you sure you want to change the base?
Conversation
final JsonParser parser, | ||
final DeserializationContext context | ||
) throws IOException { | ||
parser.nextToken(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not right: should instead check that current token is JsonToken.VALUE_NULL
: parser already points to the first token of value to deserialize.
It'd be good to maybe file issue separately, link to/from this PR. |
I'll open a PR. I just pushed a new commit, but it doesn't seem to fix the issue. |
Additional info: the same does not happen when serializing/deserializing to/from JSON. |
Ok. Thank you for verifying. I think this could be related to one oddity wrt Avro handling of |
Dammit, now I see why I couldn't find an easy way to fix it myself without consuming your limited time. But it seems a critical bug to fix, as it can break things seriously. Again, let me know if I can help you fix it. |
@marcospassos Unfortunately I do not really have time to work on this now. |
@cowtowncoder implementing a null custom serialization for an internal library, I stumbled upon a bug that prevents serialized null from being deserialized (which should affect other packages, such as JSR-353). For now, this PR only includes a test that reproduces the problem.
Error message:
Could you give me some guidance on how to fix it?