Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary semicolons #4535

Merged

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented May 17, 2024

In the spirit of conciseness, this PR skims redundant semicolons from the code base (analogous to FasterXML/jackson-core#1280).

Regarding 01f7002, i made the return path more explicit as otherwise most IDEs will flag this empty catch block (using catch (NoSuchMethodException ignored) would be another workaround, but that would still mean the return value being implicit, increasing cognitive complexity).

@cowtowncoder
Copy link
Member

Made some changes to my liking.

@cowtowncoder cowtowncoder merged commit f2045ca into FasterXML:2.18 May 17, 2024
7 checks passed
@Philzen Philzen deleted the 2-18-remove-unnecessary-semicolons branch May 17, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants