Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #838: Add Android SDK compatibility check with AnimalSniffer #841

Merged
merged 1 commit into from Nov 17, 2022
Merged

Fix #838: Add Android SDK compatibility check with AnimalSniffer #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Expand Up @@ -51,6 +51,9 @@ jobs:
- name: Extract project Maven version
id: projectVersion
run: echo ::set-output name=version::$(./mvnw org.apache.maven.plugins:maven-help-plugin:3.2.0:evaluate -DforceStdout -Dexpression=project.version -q)
- name: Verify Android SDK Compatibility
if: matrix.java_version == '8'
run: ./mvnw -B -q -ff -ntp -DskipTests animal-sniffer:check
- name: Deploy snapshot
if: github.event_name != 'pull_request' && matrix.java_version == '8' && endsWith(steps.projectVersion.outputs.version, '-SNAPSHOT')
env:
Expand Down
25 changes: 25 additions & 0 deletions pom.xml
View file
Open in desktop
Expand Up @@ -43,6 +43,13 @@
<maven.compiler.source>1.6</maven.compiler.source>
<maven.compiler.target>1.6</maven.compiler.target>

<!-- 16-Nov-2022, tatu: [core#838] Verify Android SDK compatibility.
Baseline compatibility:
* Jackson 2.13 compatible with Android SDK 19 and up
-->
<version.android.sdk>19</version.android.sdk>
<version.android.sdk.signature>0.5.0</version.android.sdk.signature>

<osgi.export>com.fasterxml.jackson.core;version=${project.version},
com.fasterxml.jackson.core.*;version=${project.version}
</osgi.export>
Expand Down Expand Up @@ -142,6 +149,24 @@ com.fasterxml.jackson.core.*;version=${project.version}
<groupId>de.jjohannes</groupId>
<artifactId>gradle-module-metadata-maven-plugin</artifactId>
</plugin>

<!-- 16-Nov-2022, tatu: [core#838] add verification of compatibility
wrt Android SDK versions using AnimalSniffer with "gummy bears" signatures.
To be run from CI, but manually with:
mvn clean package animal-sniffer:check
-->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>animal-sniffer-maven-plugin</artifactId>
<version>1.22</version>
<configuration>
<signature>
<groupId>com.toasttab.android</groupId>
<artifactId>gummy-bears-api-${version.android.sdk}</artifactId>
<version>${version.android.sdk.signature}</version>
</signature>
</configuration>
</plugin>
</plugins>
</build>

Expand Down