New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #603 #604
Fixed issue #603 #604
Conversation
@@ -3,6 +3,11 @@ | |||
import com.fasterxml.jackson.core.*; | |||
import com.fasterxml.jackson.core.json.JsonFactory; | |||
|
|||
import java.io.IOException; | |||
import java.util.Base64; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can not use until 3.0 (part of JDK 8). Same for a few other things, will make necessary changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just replaced it with a generateRandomAlpha
method.
Thank you for the fix(es)! Due to minor JDK 8 dependencies here I think I'll merge changes manually, starting with 2.10 branch. But keeping essential logic. |
@cowtowncoder I can replace the JDK8 dependencies with this function if you'd like:
Edit: done |
Jackson has full Base64 functionality in itself .... |
I don't really need base64 for this test, so it's okay... |
_currInputProcessed
,_currInputRowStart
, and_nameStartOffset
must be updated before_inputPtr
See #603