Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary semicolon #1280

Merged
merged 1 commit into from Apr 28, 2024

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Apr 26, 2024

No description provided.

@Philzen
Copy link
Contributor Author

Philzen commented Apr 26, 2024

As per FasterXML/jackson-annotations#250 (comment), moved this commit into a separate PR.

@cowtowncoder
Copy link
Member

Ok, going forward these are not kind of PRs that are super useful, and come down to stylistic differences (I somehow like trailing semicolon for enums, but YMMV). Same for semicolon for empty statements.
Does not make any difference to compiler, same resulting bytecode.

Still. I know others like minimalism so yeah, let's remove redundancy.

But like other PRs, let's re-base to 2.18.

@Philzen Philzen force-pushed the remove-unnecessary-semicolon branch from 689cabc to 661b6c2 Compare April 28, 2024 17:00
@Philzen Philzen changed the base branch from 2.15 to 2.18 April 28, 2024 17:00
@Philzen
Copy link
Contributor Author

Philzen commented Apr 28, 2024

But like other PRs, let's re-base to 2.18.

Done.

@cowtowncoder cowtowncoder merged commit 08aa368 into FasterXML:2.18 Apr 28, 2024
1 check passed
@Philzen Philzen deleted the remove-unnecessary-semicolon branch May 1, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants