Remove duplicated condition #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't plan for new releases of 2.15 so this should be rebased for 2.18 (current default). EDIT: has really no practical performance effect since it's in |
cowtowncoder
approved these changes
Apr 27, 2024
Philzen
force-pushed
the
2-15-remove-duplicated-condition
branch
from
eeaedd5
to
cf87c88
Compare
Done. |
cowtowncoder
approved these changes
Apr 28, 2024
|
LGTM, will merge. Thank you @Philzen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't checked the bytecode if this would be optimized away by the compiler or not – so cannot say whether this would also pose a nice micro-optimization.
However it simplifies the condition and reduces the code base.
Kindly advise if this is the right target branch for the PR.