Fix "iff" typo in Javadoc and comments, remove some redundant expressions #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Philzen could you hold your horses? Let's discuss the other PRs first. |
Philzen
force-pushed
the
2-15-fix-typo-iff
branch
from
b985708
to
ed8732d
Compare
Philzen
force-pushed
the
2-15-fix-typo-iff
branch
2 times, most recently
from
2890b36
to
6d43e17
Compare
|
It's not a typo: https://en.wikipedia.org/wiki/If_and_only_if so only to be removed from cases where plain "if" is better -- but I try to add it only where "if and only if" is indeed the accurate usage. |
|
Closed in favor of #1282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to FasterXML/jackson-databind#4502
Also took the liberty to remove some code lines that came up in my IntelliJ highlighting (there's a couple more regarding redundant casts and using protected modifier in a final class – however i only applied the most obvious and safe ones that simplify the class).