Prefer bitwise OR over addition for UTF-8 multi-byte encoding #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xtonik Are bitwise logical operators faster than basic arithmetic (add, sub)? Back in the days costs were similar if not identical, but I haven't really been following on how CPU instruction costs fare these days. So, basically, I assume this is expected to improve performance, but not sure how to verify: could build a micro-benchmark I guess but was guessing you have more information onthis. |
cowtowncoder
changed the title
|
@xtonik Forgot to follow up on this -- do you have something (tests, articles) to support the idea that this helps speed up processing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(contributed by @xtonik)