Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect parsing of single-quoted surrounded String values containing double quotes #721

Closed
cowtowncoder opened this issue Oct 13, 2021 · 3 comments
Closed

Incorrect parsing of single-quoted surrounded String values containing double quotes #721

cowtowncoder opened this issue Oct 13, 2021 · 3 comments
Milestone
2.13.1

Comments

@cowtowncoder
Copy link
Member

(note: created for FasterXML/jackson-databind#3301 since the issue is almost certainly in this component)

Looks like some content is incorrectly decoded when single quoted values are accepted.
@cowtowncoder cowtowncoder mentioned this issue Oct 13, 2021
Closed
@cowtowncoder cowtowncoder changed the title Issue with parsing single-quoted surrounded String values Issue with parsing single-quoted surrounded String values containing double quotes Oct 13, 2021
@cowtowncoder cowtowncoder changed the title Issue with parsing single-quoted surrounded String values containing double quotes Incorrect parsing of single-quoted surrounded String values containing double quotes Oct 13, 2021
@cowtowncoder cowtowncoder modified the milestones: 2.10, 2.13.1 Oct 13, 2021
@cowtowncoder
Copy link
Member Author

Fixed in 2.12 branch (for possible 2.12.6), but most likely will be included in 2.13.1.

@cowtowncoder
Copy link
Member Author

Thank you @wcarmon for reporting this! Handling was correct for single-quoted names, but the check that had been added there was not added in value handling.

@wcarmon
Copy link

wcarmon commented Oct 13, 2021

thanks @cowtowncoder for such a quick response!

@williamhyun williamhyun mentioned this issue Dec 28, 2021
Closed
dongjoon-hyun pushed a commit to apache/spark that referenced this issue Dec 28, 2021
@williamhyun @dongjoon-hyun
[SPARK-37763][BUILD] Upgrade jackson to 2.13.1
e653b8c 
### What changes were proposed in this pull request?
This PR aims to upgrade jackson to 2.13.1.

### Why are the changes needed?
This release has the following fix.
- FasterXML/jackson-core#721

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass the CIs.

Closes #35037 from williamhyun/jackson2131.

Authored-by: William Hyun <william@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.1
Development

No branches or pull requests
2 participants
@cowtowncoder @wcarmon