Skip to content

Commit

Permalink
Fix #838: Add Android SDK compatibility check with AnimalSniffer
Browse files Browse the repository at this point in the history
  • Loading branch information
cowtowncoder committed Nov 17, 2022
1 parent 56c3716 commit 301fd74
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/main.yml
Expand Up @@ -51,6 +51,9 @@ jobs:
- name: Extract project Maven version
id: projectVersion
run: echo ::set-output name=version::$(./mvnw org.apache.maven.plugins:maven-help-plugin:3.2.0:evaluate -DforceStdout -Dexpression=project.version -q)
- name: Verify Android SDK Compatibility
if: matrix.java_version == '8'
run: ./mvnw -B -q -ff -ntp -DskipTests animal-sniffer:check
- name: Deploy snapshot
if: github.event_name != 'pull_request' && matrix.java_version == '8' && endsWith(steps.projectVersion.outputs.version, '-SNAPSHOT')
env:
Expand Down
25 changes: 25 additions & 0 deletions pom.xml
Expand Up @@ -43,6 +43,13 @@
<maven.compiler.source>1.6</maven.compiler.source>
<maven.compiler.target>1.6</maven.compiler.target>

<!-- 16-Nov-2022, tatu: [core#838] Verify Android SDK compatibility.
Baseline compatibility:
* Jackson 2.13 compatible with Android SDK 19 and up
-->
<version.android.sdk>19</version.android.sdk>
<version.android.sdk.signature>0.5.0</version.android.sdk.signature>

<osgi.export>com.fasterxml.jackson.core;version=${project.version},
com.fasterxml.jackson.core.*;version=${project.version}
</osgi.export>
Expand Down Expand Up @@ -142,6 +149,24 @@ com.fasterxml.jackson.core.*;version=${project.version}
<groupId>de.jjohannes</groupId>
<artifactId>gradle-module-metadata-maven-plugin</artifactId>
</plugin>

<!-- 16-Nov-2022, tatu: [core#838] add verification of compatibility
wrt Android SDK versions using AnimalSniffer with "gummy bears" signatures.
To be run from CI, but manually with:
mvn clean package animal-sniffer:check
-->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>animal-sniffer-maven-plugin</artifactId>
<version>1.22</version>
<configuration>
<signature>
<groupId>com.toasttab.android</groupId>
<artifactId>gummy-bears-api-${version.android.sdk}</artifactId>
<version>${version.android.sdk.signature}</version>
</signature>
</configuration>
</plugin>
</plugins>
</build>

Expand Down

0 comments on commit 301fd74

Please sign in to comment.